[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: JDK-8187314: All Cells: must show backing data always
From:       Ajit Ghaisas <aghaisas () openjdk ! org>
Date:       2023-10-31 10:09:48
Message-ID: HFncJwB9aj5PQEZtV0B-oKF_FFerdlNyoL07zBWLr3M=.3818f9fb-b789-4b5d-968f-c7742eec79ec () github ! com
[Download RAW message or body]

On Fri, 4 Aug 2023 18:13:34 GMT, Marius Hanl <mhanl@openjdk.org> wrote:

> Before, the `updateItem` method was called with the new value that was committed \
> via `commitEdit()`. This is problematic as developers may setup a commit handler \
> via `setOnEditCommit`, which may reject the edit (or change the value otherwise). \
> We therefore do call the `updateItem(-1)` which will also call `updateItem` but \
> with the real underlying value. 
> Changed and added tests for all 4 cells.

Marked as reviewed by aghaisas (Reviewer).

-------------

PR Review: https://git.openjdk.org/jfx/pull/1197#pullrequestreview-1705906694


[prev in list] [next in list] [prev in thread] [next in thread]