[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8296266: TextArea: Navigation breaks with RTL text
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2023-09-29 14:47:31
Message-ID: E1W5WdC6ah3eMvnJ9K5m-TZG6pP1Dn8DZS5cAdep1aE=.24df80f9-712d-477a-8ee5-47f64a7b6919 () github ! com
[Download RAW message or body]

On Tue, 22 Aug 2023 20:46:21 GMT, Andy Goryachev <angorya@openjdk.org> wrote:

> The fix uses character BreakIterator instead of the logic that relies on \
> caretBounds/hitTest/rangeShape in TextInputControl.nextCharacterVisually(). 
> I believe this is a more reliable method of navigation, as it behaves in sync with \
> the jdk break iterator, thought it might work differently around grapheme clusters, \
> considering a recent change JDK-8291660 
> This change also introduces TextInputControlHelper class (impl. detail) which gives \
> access to character- and word- break iterators cached by TextInputControl (*some \
> say* these iterators and associated editing logic should be a part of Content \
> implementation, but that's a discussion for another day).

@aghaisas would you take a look please?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1220#issuecomment-1741001498


[prev in list] [next in list] [prev in thread] [next in thread]