[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8306083: Text.hitTest is incorrect when Text node is present in TextFlow [v7]
From:       Kevin Rushforth <kcr () openjdk ! org>
Date:       2023-08-29 16:03:18
Message-ID: jYWP1HC5sdAcdRvv6Y6_7WhHyHy_-9as8tqGiSlef7g=.9671767e-5169-424c-8b28-a875edd4ce61 () github ! com
[Download RAW message or body]

On Mon, 21 Aug 2023 18:25:08 GMT, Karthik P K <kpk@openjdk.org> wrote:

> > The text run selected in `PrismTextLayout::getHitInfo()` method for character \
> > index calculation was not correct when Text node was embedded in TextFlow. Hence \
> > wrong character index value was calculated for the same. 
> > Since only x, y coordinates were available in the above mentioned method, sending \
> > the text as a parameter to this method is necessary so as to know if the text run \
> > selected for character index calculation is correct. Along with this change \
> > modified the `PrismTextLayout::getHitInfo()` method to calculate the correct \
> > character index. 
> > Added tests to validate the changes.
> 
> Karthik P K has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Review comments

@prrace would you be able to review this?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1157#issuecomment-1697736509


[prev in list] [next in list] [prev in thread] [next in thread]