[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: JDK-8304439: Subscription based listeners [v6]
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2023-06-30 23:01:02
Message-ID: 8g4mZmGv2L296BlRze45BwpoM69y2WNnlSMoDldBaXc=.a8777248-1931-4fd4-bd85-8d87a8bb7546 () github ! com
[Download RAW message or body]

On Thu, 29 Jun 2023 21:38:09 GMT, John Hendrikx <jhendrikx@openjdk.org> wrote:

> > Makes `Subscription` public (removing some of its methods that are unnecessary), \
> > and adds methods that can provide `Subscription`s in `ObservableValue`.
> 
> John Hendrikx has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Changed subscription methods to use the subscribe name

modules/javafx.base/src/main/java/com/sun/javafx/binding/ConditionalBinding.java line \
102:

> 100:         }
> 101:     }
> 102: }

missing newline?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1069#discussion_r1248328610


[prev in list] [next in list] [prev in thread] [next in thread]