[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8310667: Normalize comment blocks in newly-converted package-info.java files
From:       Kevin Rushforth <kcr () openjdk ! org>
Date:       2023-06-23 13:58:11
Message-ID: bPq2sNGhF8oRXfKM9gDU6ZbthXj-qfqRU6uP39X5oyw=.44cf040e-8ad3-485c-9990-781a023ff453 () github ! com
[Download RAW message or body]

On Thu, 22 Jun 2023 18:38:43 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:

> This is a follow-up fix for \
> [JDK-8180066](https://bugs.openjdk.org/browse/JDK-8180066). As mentioned in the \
> description of PR #1159, we should normalize the javadoc comment blocks in the \
> `package-info.java` files, which were converted from `package.html`. 
> In addition to being good cleanup, it also resolves a CI test failure that was \
> introduced by [JDK-8180066](https://bugs.openjdk.org/browse/JDK-8180066), and is \
> being tracked by [JDK-8310654](https://bugs.openjdk.org/browse/JDK-8310654). 
> The generated API docs are identical before and after this fix, excluding \
> white-space changes. So the following show zero differences: 
> 
> $ diff -w -r before/build/javadoc after/build/javadoc
> 
> 
> Additionally, the following now passes, whereas it fails without this fix:
> 
> 
> $ gradle :graphics:test

Yes, the whitespace diffs are expected. Running a diff with the option to ignore \
white spaces shows zero diffs.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1160#issuecomment-1604318978


[prev in list] [next in list] [prev in thread] [next in thread]