[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8302511: HitInfo.toString() throws IllegalArgumentException [v3]
From:       Ajit Ghaisas <aghaisas () openjdk ! org>
Date:       2023-06-23 10:45:15
Message-ID: w1vJ7qBON7XLRaidrVeAM1f7vZhHEow6wPnA92GpBR0=.1d9b1d88-c55e-4b52-9e2f-8b2adbdac4a9 () github ! com
[Download RAW message or body]

On Fri, 16 Jun 2023 15:35:42 GMT, Andy Goryachev <angorya@openjdk.org> wrote:

> > A recent change in JDK-8304831 ensured that insertionIndex is always computed \
> > prior to HitInfo construction, making it possible to remove buggy logic in \
> > HitInfo.  This change also allows for removal of the 'text' field.  
> > There should be no impact since the constructor is package protected.
> 
> Andy Goryachev has updated the pull request incrementally with one additional \
> commit since the last revision: 
> whitespace

LGTM.

-------------

Marked as reviewed by aghaisas (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1154#pullrequestreview-1494905694


[prev in list] [next in list] [prev in thread] [next in thread]