[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8299756: Minor updates in CSS Reference [v3]
From:       Kevin Rushforth <kcr () openjdk ! org>
Date:       2023-05-31 23:25:10
Message-ID: HyUYyVBdon5OcmChvHhOXsiphYZc_6UG79MfkVRsNVM=.51e49c3f-57a4-405c-ab34-31cb665de9b7 () github ! com
[Download RAW message or body]

On Wed, 31 May 2023 23:14:21 GMT, Andy Goryachev <angorya@openjdk.org> wrote:

> > Minor fixes and addition of missing sections:
> > 
> > - The 'system' font is missing from the list of generic font family names in the \
> >                 <font> section. ✓
> > - Explicitly add text color property -fx-fill to Text section, so as not to \
> >                 confuse with Labeled -fx-text-fill ✓
> > - TextFlow section is missing, properties: -fx-text-alignment, -fx-line-spacing, \
> >                 -fx-tab-size ✓
> > - Text: missing -fx-line-spacing, -fx-bounds-type ✓
> > - -fx-focus-traversable is in Node and not in Control (though there is some \
> >                 relevant comment) - keep as is. ✓
> > - Node: broken link to 'Control' (sic, not Controls) in "... see Controls for \
> >                 details" ✓
> > - Missing &lt;text-bounds-type> type ✓
> 
> Andy Goryachev has updated the pull request incrementally with one additional \
> commit since the last revision: 
> pane

Marked as reviewed by kcr (Lead).

-------------

PR Review: https://git.openjdk.org/jfx/pull/1144#pullrequestreview-1454312989


[prev in list] [next in list] [prev in thread] [next in thread]