[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8223373: Remove IntelliJ IDEA specific files from the source code repository [v6]
From:       Ambarish Rapte <arapte () openjdk ! org>
Date:       2023-05-31 6:24:10
Message-ID: pe0RtfC0h8qwZf8gijw6Fd9uCAQg8mPMV3qNkNgWzVg=.ddb204c7-253f-48e8-990d-3e40632fd98d () github ! com
[Download RAW message or body]

On Sat, 15 Apr 2023 23:32:40 GMT, Thiago Milczarek Sayao <tsayao@openjdk.org> wrote:

> > This PR does:
> > 
> > - Remove specific Idea files and let it be imported from gradle;
> > - Adds checkstyle (to use with checkstyle plugin - it will let you know style \
> >                 mistakes);
> > - Configures auto-format to sun style (with the changes mentioned in [Code Style \
> >                 Rules](https://wiki.openjdk.org/display/OpenJFX/Code+Style+Rules));
> >                 
> > - Automatically sets Copyright notice (updates year too);
> 
> Thiago Milczarek Sayao has updated the pull request incrementally with two \
> additional commits since the last revision: 
> - Update .gitignore
> - Remove unrelated gitignore

Looks good.
Did not face any problem when loading the project in idea, changing properties, \
editing files.

-------------

Marked as reviewed by arapte (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1009#pullrequestreview-1452286626


[prev in list] [next in list] [prev in thread] [next in thread]