[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8233955: VM crashes if more than one file are added to ClipboardContent via drag and drop [
From:       Ambarish Rapte <arapte () openjdk ! org>
Date:       2023-05-30 16:22:07
Message-ID: 4sdvtkbw-0hkUROOXoTmSBlj4N-jnbpfcou3mSIttu4=.a752188b-b9be-44e3-bb30-cce53752be5d () github ! com
[Download RAW message or body]

On Tue, 30 May 2023 08:57:40 GMT, Lukasz Kostyra <lkostyra@openjdk.org> wrote:

> > Crashes started happening due to macOS DnD API change from macOS 10.14 onwards. \
> > 10.14 incrodues some [DnD \
> > constrains](https://developer.apple.com/documentation/macos-release-notes/appkit-release-notes-for-macos-10_14#Drag-and-Drop) \
> > which our DnD code happened to trigger on some occasions. 
> > Our code used deprecated `dragImage` API which since 10.14 had new requirement - \
> > each NSPasteboard item had to have a corresponding drag image. Not meeting this \
> > constraint raised an exception, which crashed the app. Since there was no \
> > possibility to add more drag images to `dragImage` API (it only took one NSImage \
> > as parameter) the code had to be rewritten - as such I upgraded it to new DnD API \
> > utilizing NSDraggingSession and related protocols. 
> > One side-effect of new DnD API is that it now modifies NSPasteboard for us - \
> > previous behavior was more "separated" from user code perspective (write items to \
> > pasteboard -> initiate a drag via `dragImage`). Manually updating NSPasteboard \
> > before calling `beginDraggingSessionWithItems` raised another exception related \
> > to NSPasteboard already having DnD-ed elements inside it. Some system tests, \
> > however, relied on that behavior and writing to NSPasteboard \
> > (`MacPasteboardShim.java` used in some tests creates a `Clipboard.DND` for test \
> > purposes). Since this path is in tests I assumed this behavior should stay and \
> > tried to make it as close to working as possible. Tests (including those using \
> > `MacPasteboardShim`) pass after my changes. 
> > Additionally, added a new manual test based on `DndTest.java` test which creates \
> > two temporary files and allows for testing faulty behavior.
> 
> Lukasz Kostyra has updated the pull request incrementally with one additional \
> commit since the last revision: 
> GlassDraggingSource: Update copyright header years
> 
> Year "2011" in copyright headers was a Copy-Paste's error

Marked as reviewed by arapte (Reviewer).

-------------

PR Review: https://git.openjdk.org/jfx/pull/1089#pullrequestreview-1451341039


[prev in list] [next in list] [prev in thread] [next in thread]