[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Withdrawn: 8299423: JavaFX Mac system menubar leaks
From:       duke <duke () openjdk ! org>
Date:       2023-05-29 10:09:08
Message-ID: VRbTocmJws3JO7M7ASmqQUsnZDTBnd9gUh1dDJ7gV1M=.cadabe1e-6a77-4d21-8f5f-3b574a954595 () github ! com
[Download RAW message or body]

On Fri, 30 Dec 2022 09:41:46 GMT, Florian Kirmaier <fkirmaier@openjdk.org> wrote:

> This PR fixes the leak in the mac system menu bar.
> 
> Inside the native code, NewGlobalRef is called for the callable.
> Which makes it into a "GC-Root" until DeleteGlobalRef is called.
> 
> The DeleteGlobalRef is never called for the MenuEntry, if it's removed from the \
> menu without removing it's callable. This PR adds logic, whether the Menu is \
> inserted. If it's not inserted in a Menu anymore, then DeleteGlobalRef is called, \
> by calling `_setCallback` with the callable "null". 
> The unit test verifies, that this bug happened without this change, but no longer \
> happens with this change.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jfx/pull/987


[prev in list] [next in list] [prev in thread] [next in thread]