[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Withdrawn: 8278021: Fix warnings in macOS glass native code and treat warnings as errors
From:       duke <duke () openjdk ! org>
Date:       2023-05-27 21:34:01
Message-ID: tQWp_GnBzw3VtEcLwTpxxdSXAyhbsvGvFZhTEy-KrGo=.8f8b9623-bdb1-4a71-947e-212ac2455de5 () github ! com
[Download RAW message or body]

On Wed, 1 Dec 2021 17:44:21 GMT, Martin Fox <duke@openjdk.org> wrote:

> Turning on warnings-as-errors for the macOS glass native code. Deprecated \
> declarations are excluded and still appear as warnings. 
> In the code that tries to locate the application's dock icon there were three \
> instances where `NO` was being passed into a method that required a pointer to a \
> `BOOL`, not a `BOOL`. I suspect the intent was to check that the path pointed to an \
> existing file but not a directory. Since JavaFX has gone this long without \
> screening out directories correctly I decided not to fix that behavior except at \
> the very end. 
> The only other changes of note are sending some NSNotification objects to delegate \
> API's that require them even though we know they're ignored on the other side. It \
> was the easiest way to get rid of the warning.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jfx/pull/687


[prev in list] [next in list] [prev in thread] [next in thread]