[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8304831: TextFlow.hitTest.insertionIndex incorrect with surrogate pairs
From:       Karthik P K <kpk () openjdk ! org>
Date:       2023-04-27 6:07:57
Message-ID: iEerMQgdU1ypftVDQ_V4rRiiFRw7JUpaKh71t_0DgKs=.89129776-2e64-4a70-b7bd-beb7126fb06c () github ! com
[Download RAW message or body]

On Wed, 26 Apr 2023 19:47:43 GMT, Andy Goryachev <angorya@openjdk.org> wrote:

> > I'm also seeing same issue
> 
> I wonder what could be the difference? text size?

Text size is one difference.
One more observation I made is that if the emojis and text in the TextFlow are \
separate text nodes then this fix works. If one text node contains combination of \
text and emojis then it is failing. Also the fix does not work with the first emoji \
in the following picture but works with second one. <img width="30" alt="image" \
src="https://user-images.githubusercontent.com/26969459/234771077-a5e59e05-c520-4b44-b0ff-0375f7832e48.png">


So looks like the the combination of different text and emojis are giving different \
results. I will check these and resume work on this PR after the test sprint.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1091#issuecomment-1524768053


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic