[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8286089: Intermittent WebKit build failure on macOS in JavaScriptCore
From:       Kevin Rushforth <kcr () openjdk ! org>
Date:       2023-03-29 11:21:39
Message-ID: tnjJH88L2a3xzyoY1F2JkR6T3syRp3WUZBkIi1OShgY=.f96d5965-b586-4db9-932b-aeb668516115 () github ! com
[Download RAW message or body]

On Tue, 28 Mar 2023 02:08:27 GMT, Jay Bhaskar <jbhaskar@openjdk.org> wrote:

> Issue: Error copying file (if different) from \
> Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_header.py" to \
> "modules/javafx.web/build/mac/Release/JavaScriptCcripts/builtins_generate_separate_header.py".
>  
> Root cause: The number of build threads more than 8, causing a synchronization \
> issue for builtins_generate_separate_header.py, the file needs to be copied before \
> use at build dir 
> Solution: Use the sleep of 1 second and retry 10 times to copy in CMakeList.txt and \
> execute using the execute_process cmake command

Looks good. I see that your CI test build passed on all platforms, and a continuous \
stress build on our Mac CI build machines ran for several days with no failures.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1073#pullrequestreview-1362845584


[prev in list] [next in list] [prev in thread] [next in thread]