[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Integrated: 8172849: Non-intuitive baseline alignment for labeled controls with graphics
From:       Karthik P K <kpk () openjdk ! org>
Date:       2023-03-23 11:36:53
Message-ID: 1asgHSiqMd9oEVVynwStQICQrMIL_QajW7uRaMgiCNc=.80d958ef-f30e-4b85-89fa-820e1f826828 () github ! com
[Download RAW message or body]

On Wed, 15 Mar 2023 10:58:14 GMT, Karthik P K <kpk@openjdk.org> wrote:

> Issue was observed because even when graphic height was less than text height of \
> the Label, graphic height was considered while calculating the baseline offset. \
> This was shifting the baseline offset and resulted in misalignment. 
> Updated `computeBaselineOffset` to exclude graphic height from baseline offset \
> calculation when graphic height is more than text height. 
> Added unit test to validate the fix.

This pull request has now been integrated.

Changeset: ae2e71fc
Author:    Karthik P K <kpk@openjdk.org>
Committer: Ajit Ghaisas <aghaisas@openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/ae2e71fc5ac2e6c7cf6d671c15b53249783c71b3
                
Stats:     50 lines in 2 files changed: 47 ins; 0 del; 3 mod

8172849: Non-intuitive baseline alignment for labeled controls with graphics

Reviewed-by: angorya, aghaisas

-------------

PR: https://git.openjdk.org/jfx/pull/1059


[prev in list] [next in list] [prev in thread] [next in thread]