[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8178368: Right alignment of text fields and alignment of prompt text works incorrectly [v7]
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2023-02-28 16:14:10
Message-ID: H4Q90skdFat1lN5hflsZoRJJtMiYQIsj3xCnv0lc6R4=.73162c01-4367-417c-9ae1-afbd8cc71baf () github ! com
[Download RAW message or body]

On Tue, 28 Feb 2023 13:30:57 GMT, Karthik P K <kpk@openjdk.org> wrote:

> > When Text width was more than TextField width, the logic to update \
> > `textTranslateX` in `updateCaretOff` method was causing the issue of unexpected \
> > behavior for Right and Center alignment. 
> > Made changes to update `textTranslateX` in `updateCaretOff` method only when text \
> > width is less than text field width i.e `delta` is positive.  For both right and \
> > center alignments, the `textTranslateX` value calculated in `updateTextPos` \
> > method will be updated without any condition so that expected behavior is \
> > achieved for all scenarios of text width relative to text field width.  
> > Added unit tests to validate LEFT, CENTER and RIGHT alignments. RIGHT and CENTER \
> > alignment tests are expected to fail without the fix provided in this PR.
> 
> Karthik P K has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Fix text scroll issue when right aligned

TextField behavior looks good in the tester!  The monkey says thank you.

-------------

Marked as reviewed by angorya (Committer).

PR: https://git.openjdk.org/jfx/pull/980


[prev in list] [next in list] [prev in thread] [next in thread]