[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8303217: Webview loaded webpage is not showing play, volume related buttons for embeded Aud
From:       Kevin Rushforth <kcr () openjdk ! org>
Date:       2023-02-28 15:01:31
Message-ID: RYCOycEbDgxacfRwI0C7mL3TbR-iny2MTh0xUT0XfEs=.c926e684-3c04-4251-af7e-ea6bfe55b318 () github ! com
[Download RAW message or body]

On Tue, 28 Feb 2023 14:41:59 GMT, Jay Bhaskar <jbhaskar@openjdk.org> wrote:

> > Issue: default html5 video element not showing media controls
> > Details: Media control design has been refactored in the current Webkit Gtk port. \
> > The CSS id  and properties related to media buttons, and slider have been \
> > removed, due to which the  media style mediaControlsAdwaita.css values are not \
> >                 being applied.
> > Solution: restored media control keywords and mapped to CSS keywords values.
> 
> Jay Bhaskar has updated the pull request incrementally with one additional commit \
> since the last revision: 
> add test case

As a note to other reviewers, the fix for PR #1050 was folded into this fix. There \
were overlapping changes (merge conflicts), so it was easier to resolve them in a \
single PR.

-------------

PR: https://git.openjdk.org/jfx/pull/1049


[prev in list] [next in list] [prev in thread] [next in thread]