[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8260528: Clean glass-gtk sizing and positioning code [v55]
From:       Thiago Milczarek Sayao <tsayao () openjdk ! org>
Date:       2023-02-27 0:13:40
Message-ID: z0MQkr3osSLNGJ9y7c9SUEwGAPTLoWQSwdslkMctMz4=.f3cd92c9-f9c2-419a-a5c6-f90f91705934 () github ! com
[Download RAW message or body]

> This cleans size and positioning code, reducing special cases, code complexity and \
> size. 
> Changes:
> 
> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different sizes. \
> It does not assume any size because it varies - it does cache because it's unlikely \
> to vary on the same system - but if it does occur, it will only waste a resize \
>                 event.
> - window geometry, min/max size are centralized in `update_window_constraints`;
> - Frame extents (the window decoration size used for "total window size"):
> - frame extents are received in `process_property_notify`;
> - removed quirks in java code;
> - When received, call `set_bounds` again to adjust the size (to account decorations \
>                 later received);
> - Removed `activate_window` because it's the same as focusing the window. \
>                 `gtk_window_present` will deiconify and focus it.
> - `ensure_window_size` was a quirk - removed;
> - `requested_bounds` removed - not used anymore;
> - `window_configure` incorporated in `set_bounds` with `gtk_window_move` and \
>                 `gtk_window_resize`;
> - `process_net_wm_property` is a work-around for Unity only (added a check if Unity \
>                 - but it can probably be removed at some point)
> - `restack` split in `to_front()` and `to_back()` to conform to managed code;

Thiago Milczarek Sayao has updated the pull request incrementally with one additional \
commit since the last revision:

  Fix bug when window starts maximized and restores to wrong size

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/915/files
  - new: https://git.openjdk.org/jfx/pull/915/files/75cae8ef..d3449427

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=915&range=54
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=915&range=53-54

  Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jfx/pull/915.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/915/head:pull/915

PR: https://git.openjdk.org/jfx/pull/915


[prev in list] [next in list] [prev in thread] [next in thread]