[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8303038: Glass gtk3 sends scroll events with delta(x, y) = 0 [v3]
From:       Thiago Milczarek Sayao <tsayao () openjdk ! org>
Date:       2023-02-24 0:14:08
Message-ID: fU7bOteSQ6TAnDxeBTquavtPKpIBgE4cfVMJ3xdhfRc=.4f122c97-a7f4-438f-a458-79215919d28d () github ! com
[Download RAW message or body]

On Thu, 23 Feb 2023 11:28:56 GMT, Thiago Milczarek Sayao <tsayao@openjdk.org> wrote:

> > Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore this \
> > scroll event type, deltas are sent to java with the value equal to zero. 
> > Here's whats happening:
> > 
> > We include all event masks, so when using gtk3 (>= 3.4.0) it includes \
> > `GDK_SMOOTH_SCROLL_MASK` meaning we receive duplicated events, one with  \
> > `direction = GDK_SMOOTH_SCROLL_MASK` and other with "legacy" direction (UP/DOWN). \
> >  When receiving the event corresponding to `GDK_SMOOTH_SCROLL_MASK` we ignored it \
> > causing it to send deltas (x,y) = 0. 
> > The fix now checks if `GDK_SMOOTH_SCROLL_MASK` is supported and uses it, also \
> > adding smooth scroll functionality.
> 
> Thiago Milczarek Sayao has updated the pull request incrementally with one \
> additional commit since the last revision: 
> Fix direction

I left a print statement for testing. I will remove once confirmed to work.

-------------

PR: https://git.openjdk.org/jfx/pull/1044


[prev in list] [next in list] [prev in thread] [next in thread]