[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: JDK-8223373: Remove IntelliJ IDEA specific files from the source code repository [v3]
From:       Marius Hanl <mhanl () openjdk ! org>
Date:       2023-02-23 21:32:22
Message-ID: 0jq6z0M-JH48wX_MCw4dwhYrO7g0RhF2fmfjBnJTjZw=.08fd12ba-75ae-4188-b529-a4f871be25ca () github ! com
[Download RAW message or body]

On Thu, 23 Feb 2023 00:41:28 GMT, Thiago Milczarek Sayao <tsayao@openjdk.org> wrote:

> > This PR does:
> > 
> > - Remove specific Idea files and let it be imported from gradle;
> > - Adds checkstyle (to use with checkstyle plugin - it will let you know style \
> >                 mistakes);
> > - Configures auto-format to sun style (with the changes mentioned in [Code Style \
> >                 Rules](https://wiki.openjdk.org/display/OpenJFX/Code+Style+Rules));
> >                 
> > - Automatically sets Copyright notice (updates year too);
> > - Run configurations for samples/toys and builds.
> 
> Thiago Milczarek Sayao has updated the pull request incrementally with one \
> additional commit since the last revision: 
> Use java 17 by default

Looks good to me. Tested with the latest IntelliJ version, everything works as \
expected. The addition to the `.gitignore` is also very helpful and I can confirm I \
get no unrelated IntelliJ/Sonarlint files anymore. Gradle changes also looks fine as \
far as I can tell. But someone else should probably have a look as well.

-------------

Marked as reviewed by mhanl (Committer).

PR: https://git.openjdk.org/jfx/pull/1009


[prev in list] [next in list] [prev in thread] [next in thread]