[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8290765: Remove parent disabled/treeVisible listeners [v4]
From:       John Hendrikx <jhendrikx () openjdk ! org>
Date:       2023-01-28 17:02:28
Message-ID: FswMF_keB8rckMp73bd9UCcBJsCwnTTfgVXKquli99I=.cdcf2fc2-94a3-4414-84a8-fc74820a4f6b () github ! com
[Download RAW message or body]

On Sat, 28 Jan 2023 16:24:30 GMT, Michael Strauß <mstrauss@openjdk.org> wrote:

> > `Node` adds InvalidationListeners to its parent's `disabled` and `treeVisible` \
> > properties and calls its own `updateDisabled()` and `updateTreeVisible(boolean)` \
> > methods when the property values change. 
> > These listeners are not required, since `Node` can easily call the \
> > `updateDisabled()` and `updateTreeVisible(boolean)` methods on its children, \
> > saving the memory cost of maintaining listeners and bindings.
> 
> Michael Strauß has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Initialize treeVisible field directly

Marked as reviewed by jhendrikx (Committer).

-------------

PR: https://git.openjdk.org/jfx/pull/841


[prev in list] [next in list] [prev in thread] [next in thread]