[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8292922 -  [Linux] No more drag events when new Stage is created in drag handler [v7]
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2022-12-23 16:42:54
Message-ID: 9jJgnCgv2_IsNjiBVmXwXw_9UdNryOG-Yr4VoFI8Mlc=.adff7ac7-d3e3-4c3b-ae6c-946b585e7875 () github ! com
[Download RAW message or body]

On Fri, 23 Dec 2022 13:54:56 GMT, Thiago Milczarek Sayao <tsayao@openjdk.org> wrote:

> > This PR  was previously discussed on #905.
> > 
> > The approach is to grab the keyboard focus so the window that originated the drag \
> > will keep it. 
> > I did some cleanup on grabbing related functions as well.
> > 
> > `gdk_keyboard_focus()` is deprecated, so is `gdk_device*` functions in favor of \
> > `gdk_seat*`. But that's only available in later Gtk versions. I checked and newer \
> > Gtk will use `gdk_seat*` inside the deprecated `gdk_keyboard_focus()`. 
> > Edit:
> > 
> > The current changes uses another approach that is to not ungrab pointer device \
> > when focus is received on another window. There's also some cleanup on grabbing \
> > related functions and grab moved from starting on mouse click to the actual drag.
> 
> Thiago Milczarek Sayao has updated the pull request incrementally with one \
> additional commit since the last revision: 
> Only grab once drag starts

re-tested with FxDock.  beautiful!

-------------

Marked as reviewed by angorya (Committer).

PR: https://git.openjdk.org/jfx/pull/977


[prev in list] [next in list] [prev in thread] [next in thread]