[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Integrated: 8297554: Remove Scene.KeyHandler
From:       Michael =?UTF-8?B?U3RyYXXDnw==?= <mstrauss () openjdk ! org>
Date:       2022-12-21 5:49:54
Message-ID: x-iFLBZJCwR6xbSc2CrNb3uta9T7uH4dYONVx_kQTV8=.71d8c0b9-ad8b-4cdd-9683-d56548307400 () github ! com
[Download RAW message or body]

On Thu, 24 Nov 2022 06:49:02 GMT, Michael Strauß <mstrauss@openjdk.org> wrote:

> The `Scene.KeyHandler` class doesn't seem to have a clear purpose, mixing focus \
> handling with event propagation. Since #852, `KeyHandler.setFocusVisible` is also \
> called from mouse and touch event handlers, which makes the purpose of the class \
> even less pronounced. 
> Moving the focus-related functionality next to the other focus functions in the \
> `Scene` class makes it easier to work with the code in the future. 
> With the focus-related functions gone, `KeyHandler` only contains a single, small \
> method that is called from `Scene.processKeyEvent`. For simplicity, this code can \
> be rolled into `Scene.processKeyEvent` and the now-empty `KeyHandler` class can be \
> removed.

This pull request has now been integrated.

Changeset: ac3f60cc
Author:    Michael Strauß <mstrauss@openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/ac3f60ccc1f02a146fecfb4bc388536bd70773ba
                
Stats:     190 lines in 1 file changed: 84 ins; 89 del; 17 mod

8297554: Remove Scene.KeyHandler

Reviewed-by: arapte, kcr

-------------

PR: https://git.openjdk.org/jfx/pull/962


[prev in list] [next in list] [prev in thread] [next in thread]