[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8287822: [macos] Remove support of duplicated formats from macOS [v3]
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2022-11-30 18:58:07
Message-ID: VPRO7KIk4fenqrec82R3bTfUvDBljN25GbLn3yaCa8s=.f1c02e2d-b8ea-4425-b298-b84e6b5c6ebf () github ! com
[Download RAW message or body]

On Thu, 13 Oct 2022 04:25:19 GMT, Alexander Matveev <almatvee@openjdk.org> wrote:

> > - Added support for JAR and JRT protocol to AVFoundation platform.
> > - Removed H.264/MP3 and AAC support from GStreamer platform, which was primary \
> >                 used to playback these formats for JAR and JRT protocols.
> > - Added ability to FXMediaPlayer sample to generate playlist for JAR and JRT \
> >                 protocols for testing. See FXMedia.java for how to use it.
> > - H.265/HEVC via JAR/JRT protocols should work on macOS after this change. Before \
> > it did not work because GStreamer platform did not support H.265/HEVC and \
> >                 AVFoundation did not support JAR/JRT protocols.
> > - Minor code clean up.
> > 
> > After this changes:
> > GSTPlatform: AIFF and WAV for all protocols.
> > AVFoundation: MP3, AAC, HLS, H.264 and H.265 for all protocols.
> > 
> > This change is transparent for end user and does not affect list of supported \
> > formats by JavaFX Media.
> 
> Alexander Matveev has updated the pull request incrementally with one additional \
> commit since the last revision: 
> 8287822: [macos] Remove support of duplicated formats from macOS [v3]

all my comments got explained and/or resolved.  thank you!

-------------

Marked as reviewed by angorya (Committer).

PR: https://git.openjdk.org/jfx/pull/909


[prev in list] [next in list] [prev in thread] [next in thread]