[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8295806: TableViewSkin: memory leak when changing skin [v2]
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2022-11-30 17:28:21
Message-ID: 60DMDpexucF-ykALk83CawT4BvTKw5EaOW0M3TsY2hw=.0046ba5e-efb3-470c-971d-25176ab720e9 () github ! com
[Download RAW message or body]

> as determined by SkinMemoryLeakTest (remove line 179) and a leak tester
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>  
> caused by:
> - adding and not removing listeners
> - adding and not removing event handlers/filters
> 
> NOTE:
> this fix requires [JDK-8294809](https://bugs.openjdk.org/browse/JDK-8294809) \
> ListenerHelper

Andy Goryachev has updated the pull request with a new target base due to a merge or \
a rebase. The pull request now contains 26 commits:

 - Merge remote-tracking branch 'origin/master' into
   8295806.table.view.skin
 - Merge remote-tracking branch 'origin/master' into
   8295806.table.view.skin
 - 8295806: placeholder
 - 8295806: plugged the leak
 - Merge remote-tracking branch 'origin/8294809.listener.helper' into \
                8295806.table.view.skin
 - 8294809: map change listener
 - Merge remote-tracking branch 'origin/master' into 8294809.listener.helper
 - Merge remote-tracking branch 'origin/master' into 8295806.table.view.skin
 - 8294809: generics
 - 8294809: is alive
 - ... and 16 more: https://git.openjdk.org/jfx/compare/0a785ae0...8c5f4df9

-------------

Changes: https://git.openjdk.org/jfx/pull/929/files
 Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=929&range=01
  Stats: 200 lines in 7 files changed: 95 ins; 57 del; 48 mod
  Patch: https://git.openjdk.org/jfx/pull/929.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/929/head:pull/929

PR: https://git.openjdk.org/jfx/pull/929


[prev in list] [next in list] [prev in thread] [next in thread]