[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8295531: ComboBoxBaseSkin: memory leak when changing skin [v2]
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2022-11-30 16:38:04
Message-ID: xHrf0xUxA_gElcJyrH29MslXqPpgzPBUVS-Wg1sUkjo=.0dc7c905-e9db-460a-8a42-2103a1ee4079 () github ! com
[Download RAW message or body]

> as determined by SkinMemoryLeakTest (remove line 166) and a leak tester
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>  
> Affected skins:
> - ColorPicker
> - DatePicker
> - ComboBox
> 
> caused by:
> - out-of-order modification of the control property (skin.install)
> - adding skin nodes and not removing them in dispose()
> - adding listeners and not removing them in dispose()
> 
> NOTE: the fix will require not only ListenerHelper \
> [JDK-8294809](https://bugs.openjdk.org/browse/JDK-8294809) but also Skin.install() \
> [JDK-8290844](https://bugs.openjdk.org/browse/JDK-8290844) changes.

Andy Goryachev has updated the pull request with a new target base due to a merge or \
a rebase. The pull request now contains 53 commits:

 - Merge remote-tracking branch 'origin/master' into
   8295531.color.picker.skin
 - Merge remote-tracking branch 'origin/master' into
   8295531.color.picker.skin
 - Merge remote-tracking branch 'origin/master' into 8295531.color.picker.skin
 - 8295531: whitespace
 - 8295531: selection model leak
 - Merge branch '8294809.listener.helper' into 8295531.color.picker.skin
 - 8294809: generics
 - Merge branch '8294809.listener.helper' into 8295531.color.picker.skin
 - 8294809: is alive
 - Revert "8294809: removed weak listeners support"
   
   This reverts commit 2df4a85db638d76cacaf6c54ba669cdb3dd91a18.
 - ... and 43 more: https://git.openjdk.org/jfx/compare/0a785ae0...f391f41a

-------------

Changes: https://git.openjdk.org/jfx/pull/922/files
 Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=922&range=01
  Stats: 185 lines in 6 files changed: 82 ins; 41 del; 62 mod
  Patch: https://git.openjdk.org/jfx/pull/922.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/922/head:pull/922

PR: https://git.openjdk.org/jfx/pull/922


[prev in list] [next in list] [prev in thread] [next in thread]