[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: JDK-8297413: Remove easy warnings in javafx.graphics [v2]
From:       Kevin Rushforth <kcr () openjdk ! org>
Date:       2022-11-30 12:59:36
Message-ID: enC3_8MEu9TwZ3lTwMaH31gA48KS7QA52EYKBdMhc8s=.035447b0-8fef-4a57-954a-00acc813790c () github ! com
[Download RAW message or body]

On Tue, 22 Nov 2022 21:28:44 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:

> > John Hendrikx has updated the pull request incrementally with one additional \
> > commit since the last revision: 
> > Fix indentation
> 
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/UploadingPainter.java \
> line 41: 
> > 39:  * The PresentingPainter is used when we are rendering to the main screen.
> > 40:  */
> > 41: final class UploadingPainter extends ViewPainter {
> 
> I'm not sure I see the value in making this change.

Since this is an internal class (not public API), I won't object to this change. I do \
think it's a rather pointless change, but I'll leave it up to you.

-------------

PR: https://git.openjdk.org/jfx/pull/960


[prev in list] [next in list] [prev in thread] [next in thread]