[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8295754: PaginationSkin: memory leak when changing skin
From:       Ajit Ghaisas <aghaisas () openjdk ! org>
Date:       2022-11-30 10:51:21
Message-ID: sqcSK85FvWNY4AK1f3OYqU_qbRO-MX6o9sfSNe2oA8U=.040de127-003f-45e4-88f2-ad0a901e6eac () github ! com
[Download RAW message or body]

On Thu, 20 Oct 2022 20:48:07 GMT, Andy Goryachev <angorya@openjdk.org> wrote:

> Fixes memory leaks as determined by SkinMemoryLeakTest (remove line 171) and a leak \
> tester https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>  
> Make sure to configure the current test in LeakTest:
> protected final Type WE_ARE_TESTING = Type.PAGINATION;
> 
> Found another issue: Pagination class does not survive replacing its skin (all \
> components disappear). 
> caused by:
> - adding and not removing listeners
> - adding and not removing children Nodes
> - setting control's properties in the constructor
> - incorrectly setting a clip rectangle
> 
> NOTE: the fix will requires both ListenerHelper \
> [JDK-8294809](https://bugs.openjdk.org/browse/JDK-8294809) and Skin.install() \
> [JDK-8290844](https://bugs.openjdk.org/browse/JDK-8290844) changes.

Fix looks good to me.

-------------

Marked as reviewed by aghaisas (Reviewer).

PR: https://git.openjdk.org/jfx/pull/925


[prev in list] [next in list] [prev in thread] [next in thread]