[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: JDK-8297414: Remove easy warnings in javafx.controls [v8]
From:       Nir Lisker <nlisker () openjdk ! org>
Date:       2022-11-30 0:49:19
Message-ID: SOu790VqoE4c_02ut6V3htmacxTdJgCC70C7KTIYO8Y=.3242f311-eab4-439f-903f-00f9d92c4d4a () github ! com
[Download RAW message or body]

On Tue, 29 Nov 2022 18:37:23 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:

> > interesting - there is technically no change, as `TableColumnBase` implements \
> > `EventTarget`. @hjohn does javadoc produce a different result?
> 
> I checked, and yes it does produce a different result:
> 
> Current:
> 
> 
> public class TableColumn<S,T>
> extends TableColumnBase<S,T>
> implements EventTarget
> 
> 
> After proposed change:
> 
> 
> public class TableColumn<S,T>
> extends TableColumnBase<S,T>
> 
> 
> Additionally, the class file is different. The signature for the class stored in \
> the class file has `implements EventTarget` before this change, and not after . I'm \
> not saying it's incompatible, but it is out of scope for this sort of global \
> cleanup.

How curious. I would have thought that the compiler would remove multiple inheritance \
paths and the classfile would be the same. As for the javadocs, it seems like the \
wrong behavior to me. I will try to ask on the mailing list if this is intentional.

I don't mind reverting it for this PR.

-------------

PR: https://git.openjdk.org/jfx/pull/959


[prev in list] [next in list] [prev in thread] [next in thread]