[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8295796: ScrollPaneSkin: memory leak when changing skin
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2022-11-29 16:20:10
Message-ID: EPdb_n6rSvYO-tE1J98n3SegzIHFNEqf8HU9Tf7RPKM=.420d5d52-f9fd-4e52-97c9-cf22296a89fd () github ! com
[Download RAW message or body]

On Tue, 29 Nov 2022 11:10:39 GMT, Ajit Ghaisas <aghaisas@openjdk.org> wrote:

> > as determined by SkinMemoryLeakTest (remove line 174) and a leak tester 
> > https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
> >  
> > caused by:
> > - adding and not removing listeners
> > - adding and not removing event handlers/filters
> > 
> > NOTE:
> > this fix requires JDK-8295242 scroll bar fixes, as well as JDK-8294809 \
> > ListenerHelper
> 
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/SkinMemoryLeakTest.java \
> line 173: 
> > 171:                 Pagination.class,
> > 172:                 PasswordField.class,
> > 173:                 //ScrollBar.class,
> 
> We can remove these lines instead of commenting them out.

@aghaisas : 
will clean up this area once the last PR is integrated, otherwise we'll have constant \
merge conflicts here (every skin memory leak PR touches this)

-------------

PR: https://git.openjdk.org/jfx/pull/928


[prev in list] [next in list] [prev in thread] [next in thread]