[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8265828: [TestBug] Save and restore the default Locale in javafx.base unit test LocalDateTi
From:       Kevin Rushforth <kcr () openjdk ! org>
Date:       2022-11-29 14:04:30
Message-ID: UhC3_b5G6Tnt8JJiC8M1xnonoYoIOFJTGvGSJIevIS8=.02e5cccc-2a66-4ebd-a223-5d46abd681e9 () github ! com
[Download RAW message or body]

On Tue, 29 Nov 2022 13:36:14 GMT, Lukasz Kostyra <lkostyra@openjdk.org> wrote:

> > The change moves Locale setting in the test to `@BeforeClass` and `@AfterClass` \
> > calls. `@BeforeClass` method call stores current default VM locale and applies \
> > Locale.US, while `@AfterClass` method restores old VM locale after all tests are \
> > completed. 
> > I tested it both on Mac and Windows, in both cases Locale is changed, restored \
> > properly and tests pass.
> 
> Lukasz Kostyra has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Remove unnecessary InvalidParameterException import

Marked as reviewed by kcr (Lead).

-------------

PR: https://git.openjdk.org/jfx/pull/954


[prev in list] [next in list] [prev in thread] [next in thread]