[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8254676: Alert disables Tab selection when TabDragPolicy REORDER is used
From:       Kevin Rushforth <kcr () openjdk ! org>
Date:       2022-10-27 22:56:27
Message-ID: W0_FxqnOpFPGtTtZJyI8ZlaJrU6JsaS8j8LOMvXeAl0=.5a8a2f5b-5073-4dba-b6cf-1b2634c513ac () github ! com
[Download RAW message or body]

On Sun, 11 Sep 2022 12:13:47 GMT, Johan Vos <jvos@openjdk.org> wrote:

> Don't set TabHeader to mouseTransparent, since it might get stuck in that state \
> (e.g. in case an Alert is shown). The TabPaneSkin deals with the dragging \
> internally, and does not require the dragged node to be mouseTransparent.

The fix looks fine to me. I tested it and all is as expected.

I also don't remember the reason for the initial setting of `mouseTransparent`, but \
it was in the initial implementation of draggable tabs \
[JDK-8187074](https://bugs.openjdk.org/browse/JDK-8187074). Johan's guess seems \
plausible.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.org/jfx/pull/895


[prev in list] [next in list] [prev in thread] [next in thread]