[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: WIP: 8260528: Clean glass-gtk sizing and positioning code [v17]
From:       Thiago Milczarek Sayao <tsayao () openjdk ! org>
Date:       2022-10-26 1:03:54
Message-ID: cTqkx4GAL9trTz_cZ5z9Hj39w79RGCYQLhqNQQFwliw=.50463f85-377a-4845-86a9-c8c72e470df4 () github ! com
[Download RAW message or body]

> This cleans size and positioning code, reducing special cases, code complexity and \
> size. 
> Changes:
> 
> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different sizes. \
> It does not assume any size because it varies - it does cache because it's unlikely \
> to vary on the same system - but if it does occur, it will only waste a resize \
>                 event.
> - window geometry, min/max size are centralized in update_window_constraints;
> - Frame extents (the window decoration size used for "total window size":
> - frame extents are received in process_property_notify;
> - removed quirks in java code;
> - When received, call set_bounds again to adjust the size;
> - `gtk_window_set_focus_on_map` to fix https://bugs.openjdk.org/browse/JDK-8292922 \
>                 and re-fix  https://bugs.openjdk.org/browse/JDK-8271054
> - `requested_bounds` removed - not necessary;
> - `window_configure` incorporated in set_bounds with `gtk_window_move` and \
> `gtk_window_resize`

Thiago Milczarek Sayao has updated the pull request incrementally with one additional \
commit since the last revision:

  Partially prevent focus stealing notification

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/915/files
  - new: https://git.openjdk.org/jfx/pull/915/files/52cb9af5..4a2ed9e6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=915&range=16
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=915&range=15-16

  Stats: 13 lines in 1 file changed: 6 ins; 6 del; 1 mod
  Patch: https://git.openjdk.org/jfx/pull/915.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/915/head:pull/915

PR: https://git.openjdk.org/jfx/pull/915


[prev in list] [next in list] [prev in thread] [next in thread]