[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v5]
From:       John Hendrikx <jhendrikx () openjdk ! org>
Date:       2022-09-29 15:02:14
Message-ID: W04MllHtsQH1gQsMffSDMdsEicBrt0zym7fyju9435U=.e9f0551c-a835-4227-b548-73b3551ae7d2 () github ! com
[Download RAW message or body]

On Mon, 26 Sep 2022 23:30:03 GMT, Nir Lisker <nlisker@openjdk.org> wrote:

> Implementation and tests look good. Left a few minor comments.
> 
> in `ObjectBinding.java`, the change in a previous PR was integrated. I think that \
> you need to merge master to not show this as a change in this PR.

I've merged in master.
 
> I will have a look at the changes to `Node` soon. I'm not sure if they need to be \
> in this PR, but I personally don't mind. Will also do some sanity checks manually \
> to see that the binding functions the way I think it should (as I have done in the \
> previous fluent binding PR), but I don't foresee any issues.

It would be good to have changes in `Node` as well as they help with the goal of this \
issue (deterministic ways to manage listeners), but not required.  If we take them \
out, I'll have to update one of the examples that assumes it is part of this PR.

-------------

PR: https://git.openjdk.org/jfx/pull/830


[prev in list] [next in list] [prev in thread] [next in thread]