[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Integrated: 8293971: Loading new Media from resources can sometimes fail when loading from FXML
From:       Alexander Matveev <almatvee () openjdk ! org>
Date:       2022-09-28 20:36:21
Message-ID: euyuOLxlUP2mORydWHAEvOUUfhKGdhcs11VyKJ5Nfok=.0842b08a-3adf-41e6-988b-826914a2588b () github ! com
[Download RAW message or body]

On Sat, 24 Sep 2022 03:07:00 GMT, Alexander Matveev <almatvee@openjdk.org> wrote:

> There was two problems:
> - uri.getPath() was returning null for jar URI, since it is not a standard URI and \
>                 thus we did not detect file type based on extension.
> - Our signature detection for MP3 had a bug and did not detect MP3 correctly. See \
> comments in code. 
> Fixed by adding function to extract file name from jar URI and also signature \
> detection was fixed for MP3.

This pull request has now been integrated.

Changeset: 35675c8d
Author:    Alexander Matveev <almatvee@openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/35675c8d27d54a26059b182614e18152794dbcec
                
Stats:     53 lines in 2 files changed: 42 ins; 0 del; 11 mod

8293971: Loading new Media from resources can sometimes fail when loading from FXML

Reviewed-by: angorya, kcr

-------------

PR: https://git.openjdk.org/jfx/pull/902


[prev in list] [next in list] [prev in thread] [next in thread]