[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8293971: Loading new Media from resources can sometimes fail when loading from FXML [v2]
From:       Kevin Rushforth <kcr () openjdk ! org>
Date:       2022-09-28 11:38:27
Message-ID: -otDan8uQHJxkC6m1qNA7Z9PNr9--ZGVX1n5w2_bMTA=.888c3311-2f7b-406f-b0d5-fe1a5bf01434 () github ! com
[Download RAW message or body]

On Tue, 27 Sep 2022 01:22:41 GMT, Alexander Matveev <almatvee@openjdk.org> wrote:

> > There was two problems:
> > - uri.getPath() was returning null for jar URI, since it is not a standard URI \
> >                 and thus we did not detect file type based on extension.
> > - Our signature detection for MP3 had a bug and did not detect MP3 correctly. See \
> > comments in code. 
> > Fixed by adding function to extract file name from jar URI and also signature \
> > detection was fixed for MP3.
> 
> Alexander Matveev has updated the pull request incrementally with one additional \
> commit since the last revision: 
> 8293971: Loading new Media from resources can sometimes fail when loading from FXML \
> [v2]

Marked as reviewed by kcr (Lead).

-------------

PR: https://git.openjdk.org/jfx/pull/902


[prev in list] [next in list] [prev in thread] [next in thread]