[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8290844: Add Skin.install() method [v4]
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2022-08-31 15:22:22
Message-ID: ITOj2Dyb6JIOBURVIqHge0UmGJRwkX6ut5Ln-7YtfAI=.7a879fd5-0131-4075-ae12-2ecc6cb3bf3e () github ! com
[Download RAW message or body]

On Wed, 24 Aug 2022 16:08:32 GMT, Jeanette Winzenburg <fastegal@openjdk.org> wrote:

> > Andy Goryachev has updated the pull request incrementally with one additional \
> > commit since the last revision: 
> > 8290844: review comments
> 
> ahh .. at least I seem to see now where we talked past each other: 
> 
> YY userYY;
> // install
> userYY = control.getYY();
> control.setYY(myYY);
> 
> // dispose: reset to previous user installed YY
> if (getSkinnable().getYY() == myYY) getSkinnable().setYY(userYY);
> 
> not sure if that's anything we want to do, and also not  a pattern currently used \
> anywhere in our skins  
> Anyway, off for today, need food and family :)

Dear @kleopatra  : 

Are we in agreement that the issue with setting a field (that cannot be reimplemented \
via add/remove listener) cannot be fixed without adding install() method, or should I \
provide a clearer example?

I'd like to move this PR forward, if possible.

Thank you.

-------------

PR: https://git.openjdk.org/jfx/pull/845


[prev in list] [next in list] [prev in thread] [next in thread]