[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8217853: Cleanup in the D3D native pipeline [v5]
From:       Nir Lisker <nlisker () openjdk ! org>
Date:       2022-08-30 18:41:25
Message-ID: uOY7x_gCJCrB6BFYbizqNK2KncWYcBehGSv9LCgnpoM=.27fb0c6a-015a-43e6-a943-f4ec0cb1bb85 () github ! com
[Download RAW message or body]

On Fri, 26 Aug 2022 17:34:41 GMT, Ambarish Rapte <arapte@openjdk.org> wrote:

> > What do you mean by "revert the type function parameter here"? Doesn't the type \
> > parameter match after a change to the gradle file?
> 
> > What do you mean by "revert the type function parameter here"?
> 
> `VsOutput main(VsInput vsInput)`: in the declaration, the type of function \
> parameter `VsInput vsInput` should be reverted with change in build.gradle. \
> `VsOutput main(VsInput vsInput)` should be changed to `VsOutput main(VertexType \
> vsInput)`

I still don't understand. What is `VertexType`? I see a comment on `VsInput` "// this \
is a .hlsl mirror of the vertex format, see VertexTypes.h". If the gradle file has \
`"/DVertexType=VsInput"`, shouldn't it be fine with `VsInput` as the main function \
argument?

-------------

PR: https://git.openjdk.org/jfx/pull/789


[prev in list] [next in list] [prev in thread] [next in thread]