[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8292353: TableRow vs. TreeTableRow: inconsistent visuals in cell selection mode [v10]
From:       Kevin Rushforth <kcr () openjdk ! org>
Date:       2022-08-27 14:29:23
Message-ID: 3Xk0Mh26ZuCoC_z_AcA5LxQTxwltSBos1u57MRtiQ2c=.1e505f8d-ab43-439d-b267-98591eb4d684 () github ! com
[Download RAW message or body]

On Wed, 24 Aug 2022 22:03:26 GMT, Andy Goryachev <angorya@openjdk.org> wrote:

> > The issue is caused by TreeTableRow incorrectly selected when cell selection mode \
> > is enabled. 
> > Changes:
> > - modified TreeTableRow.updateSelection()
> 
> Andy Goryachev has updated the pull request incrementally with one additional \
> commit since the last revision: 
> 8292353: whitespace

I haven't looked at these specific tests in detail, but as a general practice I see \
value in having both types of tests: unit tests that test a specific thing, and tests \
of various scenarios.

-------------

PR: https://git.openjdk.org/jfx/pull/875


[prev in list] [next in list] [prev in thread] [next in thread]