[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Integrated: 8292391: Add support for optional signing of native libraries
From:       Kevin Rushforth <kcr () openjdk ! org>
Date:       2022-08-23 11:04:50
Message-ID: jXN9KMGx1A0bv8WGtfLzytHzg4FoyOK2OyOeV7j6a6I=.013bd360-6898-4f5b-be6c-b5fb001cb4fc () github ! com
[Download RAW message or body]

On Tue, 16 Aug 2022 21:14:42 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:

> This PR enables an optional signing step inserted into the build right after the \
> step to strip binaries that was added by \
> [JDK-8278260](https://bugs.openjdk.org/browse/JDK-8278260). As is the case with the \
> `strip` step, the optional signing is only ever enabled for production builds when \
> running with `gradle -PCONF=Release`. 
> This is an optional step, meaning that `codeSignCmd` and `codeSignArgs` need to be \
> provided by scripts external to the repo in order to enable it. By default, they \
> are not defined, so the additional logic added by this PR will do nothing. 
> NOTE: as with the fix for \
> [JDK-8278260](https://bugs.openjdk.org/browse/JDK-8278260), this PR adds three \
> copies of the build logic. I filed \
> [JDK-8292506](https://bugs.openjdk.org/browse/JDK-8292506) to refactor both of them \
> (strip and sign), and to look for other duplication as well.

This pull request has now been integrated.

Changeset: dee34b42
Author:    Kevin Rushforth <kcr@openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/dee34b42d3443466d81fc4e2a9a2994338b680c0
                
Stats:     54 lines in 1 file changed: 54 ins; 0 del; 0 mod

8292391: Add support for optional signing of native libraries

Reviewed-by: arapte

-------------

PR: https://git.openjdk.org/jfx/pull/871


[prev in list] [next in list] [prev in thread] [next in thread]