[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8285534: Update the 3D lighting test sample [v3]
From:       Nir Lisker <nlisker () openjdk ! java ! net>
Date:       2022-04-28 17:28:34
Message-ID: pjoqC3jtNJeAG4i0DCBzwO4XgL0MAhcswEBBxu60KUI=.fb36339b-80d1-49df-8229-8811ba41c96e () github ! com
[Download RAW message or body]

> Update the the test utility. Includes:
> * Refactoring since there is no more need the split pre- and post-attenuation and \
>                 light types.
> * Added customizable material to the `Boxes` to test the interaction between lights \
>                 and materials..
> * Light colors can now be changed.
> 
> Note that GitHub decided to count the removal of the `AttenLightingSample` and \
> addition of the `Controls` file as renaming. The sample is now run now only through \
> `LightingSample`.

Nir Lisker has updated the pull request incrementally with one additional commit \
since the last revision:

  Added ambient lights

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/787/files
  - new: https://git.openjdk.java.net/jfx/pull/787/files/dae9c1d7..cbca5f8f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=787&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=787&range=01-02

  Stats: 23 lines in 3 files changed: 18 ins; 2 del; 3 mod
  Patch: https://git.openjdk.java.net/jfx/pull/787.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/787/head:pull/787

PR: https://git.openjdk.java.net/jfx/pull/787


[prev in list] [next in list] [prev in thread] [next in thread]