[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8255940: localStorage is null after window.close() [v5]
From:       Kevin Rushforth <kcr () openjdk ! java ! net>
Date:       2022-02-28 15:03:57
Message-ID: dmFcDX598wl_GAByqX_YB-gOyCM42BRBsejcsCI97zA=.404ba8d1-5929-49a9-8d1a-5663b76124ca () github ! com
[Download RAW message or body]

On Sun, 27 Feb 2022 05:35:23 GMT, Jay Bhaskar <duke@openjdk.java.net> wrote:

> > Issue: The current implementation of DOMWindow ::localStorage(..) returns null \
> >                 pointer in case of page is being closed. 
> > Fix: It should not return nullptr , as per the [w3c web storage \
> > spec](https://www.w3.org/TR/2016/REC-webstorage-20160419/)  "User agents should \
> > expire data from the local storage areas only for security reasons or when \
> > requested to do so by the user. User agents should always avoid deleting data \
> > while a script that could access that data is running."
> 
> Jay Bhaskar has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Add Review Changes

modules/javafx.web/src/test/java/test/javafx/scene/web/LocalStorageTest.java line 55:

> 53: 
> 54:     private static final File LOCAL_STORAGE_DIR = new File("LocalStorageDir");
> 55:     private static final File PRE_LOCKED = new File("zoo_local_storage");

> LOCAL_STORAGE_DIR is used by web engine , to store local data in this case

Yes, `LOCAL_STORAGE_DIR` is needed. I only meant that `PRE_LOCKED` was unused. GitHub \
decided to highlight both lines.

-------------

PR: https://git.openjdk.java.net/jfx/pull/703


[prev in list] [next in list] [prev in thread] [next in thread]