[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8278759 : PointerEvent: buttons property set to 0 when mouse down [v3]
From:       Jay Bhaskar <duke () openjdk ! java ! net>
Date:       2022-02-28 10:01:52
Message-ID: e14NBr-ie-lLDnnFmz2EEv9lEszCG6sLPbhIfQMdLhM=.bd5ede7b-6c4d-41a5-b52d-8f20802e1637 () github ! com
[Download RAW message or body]

On Fri, 25 Feb 2022 17:54:48 GMT, Hima Bindu Meda <duke@openjdk.java.net> wrote:

> > Basically, buttons property is a mask which represents the button/buttons clicked \
> > on the mouse. It is observed that event.buttons property is set to 0 when there \
> > is mouse press or drag event.This behaviour is observed only with javafx \
> > webView.Other browsers set the buttons property to 1, when there is mouse press \
> > or drag. The issue happens because the buttons property is not updated in the \
> > framework. Added implementation to update and propagate the buttons property from \
> > javafx platform to native webkit.Added a robot test case for the same. Performed \
> > sanity testing with the added implementation and the buttons property is \
> > compliant with the specification mentioned in \
> > https://w3c.github.io/pointerevents/#the-buttons-property.
> 
> Hima Bindu Meda has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Use ESC key so that the popup, if any, disappears

+ looks good

-------------

Marked as reviewed by jaybhaskar@github.com (no known OpenJDK username).

PR: https://git.openjdk.java.net/jfx/pull/742


[prev in list] [next in list] [prev in thread] [next in thread]