[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8251481: TableCell accessing row: NPE on auto-sizing [v3]
From:       Jeanette Winzenburg <fastegal () openjdk ! java ! net>
Date:       2022-01-29 14:01:16
Message-ID: 0KfzvfTmEt753F_yPzBc4bLtS9uvXaAvy8Np7SSqLcM=.e84d2e84-14e4-42ad-ad7f-2a9aa6b704c1 () github ! com
[Download RAW message or body]

On Thu, 27 Jan 2022 20:38:56 GMT, Marius Hanl <mhanl@openjdk.org> wrote:

> > This PR will fix a simple NPE which may happens when using the `TableRow` inside \
> > a `TableCell` during the initial auto sizing. In the auto sizing code, no \
> > `TableRow` is set, therefore `getTableRow()` will return null and it is not \
> > possible to e.g. access the row item. 
> > This is fixed by adding the `TableRow` in the `resizeColumnToFitContent` method, \
> > similar as it is already done for the `TreeTableView` (`TreeTableRow`).
> 
> Marius Hanl has updated the pull request incrementally with one additional commit \
> since the last revision: 
> 8251481: Using global stageLoader now

looks good (there's one minor thingy in completely aligning the test for TreeTable)

modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableCellTest.java \
line 690:

> 688:      */
> 689:     @Test
> 690:     public void testRowIsNotNullWhenAutoSizing() {

same as autosizing test for TableCell: would like the issue id :)

-------------

Marked as reviewed by fastegal (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/716


[prev in list] [next in list] [prev in thread] [next in thread]