[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8269907 memory leak - Dirty Nodes / Parent removed [v5]
From:       Florian Kirmaier <fkirmaier () openjdk ! java ! net>
Date:       2022-01-27 14:50:16
Message-ID: MST5hF718uGNafUwEPo9hEiP3QQM_e4on3EMEzVN3Es=.33fc0ad0-7674-4fc0-a0db-f2ce107ba3df () github ! com
[Download RAW message or body]

> After thinking about this issue for some time, I've now got a solution.
> I know put the scene in the state it is, before is was shown, when the dirtyNodes \
> are unset, the whole scene is basically considered dirty.  This has the drawback of \
> rerendering, whenever a window is "reshown", but it restores sanity about memory \
> behaviour, which should be considered more important.

Florian Kirmaier has updated the pull request incrementally with one additional \
commit since the last revision:

  JDK-8269907
  Removed the sync methods for the scene, because they don't work when peer is null, \
and they are not necessary.

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/584/files
  - new: https://git.openjdk.java.net/jfx/pull/584/files/29b90745..22326ccf

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=584&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=584&range=03-04

  Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/584.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/584/head:pull/584

PR: https://git.openjdk.java.net/jfx/pull/584


[prev in list] [next in list] [prev in thread] [next in thread]