[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the b
From:       Marius Hanl <mhanl () openjdk ! java ! net>
Date:       2022-01-26 15:33:41
Message-ID: YmdYusIyEMvXKpwkbgcVT9cs4pfoM0ziyY_379FObEM=.62dedc9a-4fb4-43b5-b9c6-aa8da0d60ff5 () github ! com
[Download RAW message or body]

On Wed, 26 Jan 2022 05:36:07 GMT, meghanEmbrace <duke@openjdk.java.net> wrote:

> > With a touch-enabled device, the scrollbar disappears a short while after it's \
> > used. During the layout, updateHbar() checks the hbar visibility and resets the \
> > clip, causing the user to be scrolled fully to the left when trying to access \
> > columns on the right. Using hbar.isVisible() is not feasible as there are times \
> > when the scrollbar is necessary but not visible (such as on touch-enabled devices \
> > where the scrollbar disappears when not in use, or when hidden by CSS). Hence, it \
> > is more reliable to use the variable that determines whether the hbar is \
> > necessary.
> 
> meghanEmbrace has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Updated test name to be more descriptive.

Looks good to me too.
Tested with `-Dcom.sun.javafx.touch=true` and also without to make sure there is no \
regression.

-------------

Marked as reviewed by mhanl (Author).

PR: https://git.openjdk.java.net/jfx/pull/688


[prev in list] [next in list] [prev in thread] [next in thread]