[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [jfx18] RFR: 8205915: [macOS] Accelerator assigned to button in dialog fires menuItem in owning 
From:       Jose Pereda <jpereda () openjdk ! java ! net>
Date:       2022-01-20 12:22:58
Message-ID: POq3F3B62u70O1eZoCml0WhLJZIyBMNQ2JvoHoSHQWs=.5c8b8dc9-979b-422d-bf06-d90d54dd6786 () github ! com
[Download RAW message or body]

On Wed, 19 Jan 2022 19:43:38 GMT, Martin Fox <duke@openjdk.java.net> wrote:

> > When a window is closed while handling performKeyEquivalent the same NSEvent \
> > might be passed to the new key window causing it to being processed twice. Long \
> > ago a fix was put in for this case; when the GlassWindow was closed a flag was \
> > set to ensure that we would return YES from performKeyEquivalent. To fix RT-39813 \
> > the closing of the window was deferred causing the flag to be set too late. This \
> > PR simply sets that flag when we schedule the close event instead of when the OS \
> > actually closes the window. 
> > This is a spot-fix for a larger problem, namely that we have no way of knowing \
> > whether a performKeyEquivalent event was consumed or not. The changes for fixing \
> > that are in PR #694. The changes got bundled into that PR only because there's a \
> > lot of files involved and the exact same code paths are touched. 
> > System test is included (I'm surprised, it really is possible to generate \
> > Cmd+Enter using a Robot). This is new territory for me so I have a manual test I \
> > can submit as a backup.
> 
> Martin Fox has updated the pull request incrementally with one additional commit \
> since the last revision: 
> More coding standard tweaks

Tested again, looks good

-------------

Marked as reviewed by jpereda (Committer).

PR: https://git.openjdk.java.net/jfx/pull/715


[prev in list] [next in list] [prev in thread] [next in thread]