[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8203463: [Accessibility, Narrator] NPE in TableView
From:       Kevin Rushforth <kcr () openjdk ! java ! net>
Date:       2021-12-22 13:56:17
Message-ID: hxNWd3szZq_UtGTHtU7mNG9WwbOkcUSCBC1CvLGv218=.ea67c8e0-dcc1-4f5c-a06e-3f3b57203d3f () github ! com
[Download RAW message or body]

On Wed, 22 Dec 2021 08:59:53 GMT, eduardsdv <duke@openjdk.java.net> wrote:

> The NullPointer occurs when `Accessible.getAttribute(Object)` returns null. 
> I checked all places where the `getAttribute(..)` method is called. Everywhere it \
> is checked for null `(Accessible,` `MacAccessible,` `WinAccessible,` \
> `WinTextRangeProvider`). Only at this one place in \
> `WinAccessible.GetPatternProvider(int)` it is missing. 
> This PR adds this missing null-check in the `WinAccessible.GetPatternProvider(int)` \
> method.

This looks like an obviously correct fix to me.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/700


[prev in list] [next in list] [prev in thread] [next in thread]