[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: DRAFT 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout [
From:       Martin Fox <duke () openjdk ! java ! net>
Date:       2021-12-17 18:36:22
Message-ID: PaGV4ULtq8Jb8ueMQh7MP7UjaXZeO1VHVnhZ4tyNbbU=.10c2b874-83ae-4473-9b9f-556d291ee832 () github ! com
[Download RAW message or body]

On Mon, 13 Dec 2021 19:40:47 GMT, Martin Fox <duke@openjdk.java.net> wrote:

> > There was a mismatch between the way `get_glass_key` generated the Java key code \
> > for a given key press and how `getKeyCodeForChar` determined the key code for the \
> > matching character. For example, when pressing the plus sign on a US keyboard \
> > `get_glass_key` correctly generated `KeyCode.EQUALS` but `getKeyCodeForChar("+")` \
> > generated `KeyCode.PLUS`. 
> > In this PR `getKeyCodeForChar` mirrors the behavior of `get_glass_key`; it \
> > determines which key the character lies on and generates a key code based on the \
> > unshifted character on  the same key. 
> > I'm working on a more comprehensive test case that allows you to press any key on \
> > the keyboard and test whether a KeyCharacterCombination for that character will \
> > succeed or not. I've attached it to this thread. It might be worth submitting as \
> > a manual test case \
> > [CharComboTest.txt](https://github.com/openjdk/jfx/files/7247265/CharComboTest.txt)
> >                 
> > .
> 
> Martin Fox has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Learn-as-they-type approach to implementing getKeyCodeForChar

I marked this as draft in hopes that #694 goes through instead. The review cycles \
were useful as very similar code is in #694 and will be needed to address \
[JDK-8278924](https://bugs.openjdk.java.net/browse/JDK-8278924).

-------------

PR: https://git.openjdk.java.net/jfx/pull/635


[prev in list] [next in list] [prev in thread] [next in thread]