[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    RFR: 8272118: ListViewSkin et al: must not cancel edit on scrolling
From:       Jeanette Winzenburg <fastegal () openjdk ! java ! net>
Date:       2021-11-25 15:52:26
Message-ID: H6lUmDvhZAOKY0HZF9CLx4fY6Dw5y3gEPR2n0bIi-9Y=.34c80ae4-285a-4ae2-85e8-620b199b613a () github ! com
[Download RAW message or body]

Issue was that mouse pressed on the scrollbars of all virtualized controls cancelled \
the edit. That's inconsistent with other scroll triggers (mouseWheel, programmatic). \
Fixed by removing the cancel.

Added tests that failed/passed before/after the fix. Also added tests that passed \
both before/after to guarantee that required functionality of the mouse pressed (= \
requesting focus on the control if needed) is still working.

-------------

Commit messages:
 - 8272118: ListViewSkin et al: must not cancel edit on scrolling

Changes: https://git.openjdk.java.net/jfx/pull/682/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=682&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8272118
  Stats: 594 lines in 6 files changed: 566 ins; 28 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/682.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/682/head:pull/682

PR: https://git.openjdk.java.net/jfx/pull/682


[prev in list] [next in list] [prev in thread] [next in thread]