[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8274061: Tree-/TableRowSkin: misbehavior on switching skin [v5]
From:       Kevin Rushforth <kcr () openjdk ! java ! net>
Date:       2021-11-25 1:03:08
Message-ID: WHxHDmdpbjxtbuHLukcWcG3MQFUvOHRpeQpK4Cno5S0=.3d035e72-b198-4f02-bb47-72e8eda501e4 () github ! com
[Download RAW message or body]

On Fri, 19 Nov 2021 11:42:16 GMT, Jeanette Winzenburg <fastegal@openjdk.org> wrote:

> > Cleanup of Tree-/TableRowSkin to support switching skins
> > 
> > The misbehavior/s
> > - memory leaks due to manually registered listeners that were not removed
> > - side-effects due to listeners still active on old skin (like NPEs)
> > 
> > Fix
> > - use skin api for all listener registration (for automatic removal in dispose)
> > - ~~do not install listeners that are not needed (fixedCellSize, same as in fix \
> > of ListCellSkin [JDK-8246745](https://bugs.openjdk.java.net/browse/JDK-8246745))~~ \
> > not handled here, see \
> > [JDK-8277000](https://bugs.openjdk.java.net/browse/JDK-8277000) 
> > Added tests for each listener involved in the fix to guarantee it's still working \
> > and does not have unwanted side-effects after switching skins. 
> > Note: there are pecularities in row skins (like not updating themselves on \
> > property changes of its control, throwing NPEs when not added to a VirtualFlow) \
> > which are not part of this issue but covered in \
> > [JDK-8274065](https://bugs.openjdk.java.net/browse/JDK-8274065)
> 
> Jeanette Winzenburg has updated the pull request incrementally with one additional \
> commit since the last revision: 
> changes as requested in review

Looks good.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/632


[prev in list] [next in list] [prev in thread] [next in thread]